Guards Update: cannedKeyAlgoNames #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update the guards around the strings used to make the cannedKeyAlgoNames. If any algorithm is disabled, leave it out of the list. (I'm looking at you Ed25519!) 2. Added comments to those guards. 3. Reflow the alignment.
JacobBarthelmeh
approved these changes
May 16, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
Guards Update: cannedKeyAlgoNames
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
Guards Update: cannedKeyAlgoNames
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Guards Update: cannedKeyAlgoNames
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Guards Update: cannedKeyAlgoNames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Build wolfSSL
Build and test wolfSSH
For the failure case, this client connection attempt should indicate a -1051 error occurred.